Forward-declare imports in Binding and FabricMountingManager #36609
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D44221018 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D44221018 |
javache
added a commit
to javache/react-native
that referenced
this pull request
Mar 23, 2023
…k#36609) Summary: Pull Request resolved: facebook#36609 Some random cleanup as I prepare to make these classes a better injection point for future experiments. * Forward-declare classes where possible to reduce header import * Return references to shared_ptr instead of copies when there are no lifetime concerns * Use a shared JClass instance in JFabricUIManager Changelog: [Internal] Reviewed By: rshest Differential Revision: D44221018 fbshipit-source-id: 774f77ab9827dce9b068eb7b85146409e2b08af7
javache
force-pushed
the
export-D44221018
branch
from
8510436
to
deda553
Compare
|
This pull request was exported from Phabricator. Differential Revision: D44221018 |
javache
added a commit
to javache/react-native
that referenced
this pull request
Mar 23, 2023
…k#36609) Summary: Pull Request resolved: facebook#36609 Some random cleanup as I prepare to make these classes a better injection point for future experiments. * Forward-declare classes where possible to reduce header import * Return references to shared_ptr instead of copies when there are no lifetime concerns * Use a shared JClass instance in JFabricUIManager Changelog: [Internal] Reviewed By: rshest Differential Revision: D44221018 fbshipit-source-id: 383faea5efa09fd88104decec73cbc93e13d2058
javache
force-pushed
the
export-D44221018
branch
from
deda553
to
09cac7b
Compare
…k#36609) Summary: Pull Request resolved: facebook#36609 Some random cleanup as I prepare to make these classes a better injection point for future experiments. * Forward-declare classes where possible to reduce header import * Return references to shared_ptr instead of copies when there are no lifetime concerns * Use a shared JClass instance in JFabricUIManager Changelog: [Internal] Reviewed By: rshest Differential Revision: D44221018 fbshipit-source-id: 2cf673f6ef5cdf69fa7369c8561ba059662ddb0c
|
This pull request was exported from Phabricator. Differential Revision: D44221018 |
javache
force-pushed
the
export-D44221018
branch
from
09cac7b
to
b895fdc
Compare
Base commit: 3759a26 |
|
This pull request has been merged in 7259cb3. |
jeongshin
pushed a commit
to jeongshin/react-native
that referenced
this pull request
May 7, 2023
…k#36609) Summary: Pull Request resolved: facebook#36609 Some random cleanup as I prepare to make these classes a better injection point for future experiments. * Forward-declare classes where possible to reduce header import * Return references to shared_ptr instead of copies when there are no lifetime concerns * Use a shared JClass instance in JFabricUIManager Changelog: [Internal] Reviewed By: rshest Differential Revision: D44221018 fbshipit-source-id: 1660cac964abd10ce798473e26841503430efdfe
OlimpiaZurek
pushed a commit
to OlimpiaZurek/react-native
that referenced
this pull request
May 22, 2023
…k#36609) Summary: Pull Request resolved: facebook#36609 Some random cleanup as I prepare to make these classes a better injection point for future experiments. * Forward-declare classes where possible to reduce header import * Return references to shared_ptr instead of copies when there are no lifetime concerns * Use a shared JClass instance in JFabricUIManager Changelog: [Internal] Reviewed By: rshest Differential Revision: D44221018 fbshipit-source-id: 1660cac964abd10ce798473e26841503430efdfe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Some random cleanup as I prepare to make these classes a better injection point for future experiments.
Changelog: [Internal]
Reviewed By: rshest
Differential Revision: D44221018